Skip to content

test_runner: refactor coverage report output for readability #47791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 11 commits into from
Jun 7, 2023
Merged

test_runner: refactor coverage report output for readability #47791

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d177485
test_runner: refactor coverage report output for readability
dmnsgn Apr 30, 2023
be8cdf8
lib: add yellow to colors util
dmnsgn Apr 30, 2023
e024399
test_runner: use yellow from util/colors
dmnsgn Apr 30, 2023
6bbe5b7
test_runner: memoize coverage report table line
dmnsgn Apr 30, 2023
1f9ad76
test_runner: use primordial StringPrototypeRepeat
dmnsgn Apr 30, 2023
d22b485
test_runner: extract horizontal ellipsis unicode character into a con…
dmnsgn Apr 30, 2023
04d2b78
test_runner: use StringPrototypeSlice primordial instead of substring…
dmnsgn Apr 30, 2023
b7cdf96
test_runner: default coverage report availableWidth to Infinity
dmnsgn Apr 30, 2023
dbafa5b
test_runner: pass pad, truncate and coverage as arguments to coverage…
dmnsgn Apr 30, 2023
98a327b
test_runner: remove quotes for coverageColors properties
dmnsgn Apr 30, 2023
fdade11
Update lib/internal/test_runner/utils.js
MoLow Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test_runner: pass pad, truncate and coverage as arguments to coverage… 
… report getCell
  • Loading branch information
@dmnsgn
dmnsgn committed Jun 6, 2023
commit dbafa5b47fd6d373c3dbc0870d1d45c07fdf594b
18 changes: 9 additions & 9 deletions lib/internal/test_runner/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ function getCoverageReport(pad, summary, symbol, color, table) {
}


function getCell(string, width, { pad, truncate, coverage }) {
function getCell(string, width, pad, truncate, coverage) {
if (!table) return string;

let result = string;
Expand All @@ -374,9 +374,9 @@ function getCoverageReport(pad, summary, symbol, color, table) {

// Head
if (table) report += addTableLine(prefix, tableWidth);
report += `${prefix}${getCell('file', filePadLength, { pad: StringPrototypePadEnd, truncate: truncateEnd })}${kSeparator}` +
`${ArrayPrototypeJoin(ArrayPrototypeMap(kColumns, (column, i) => getCell(column, columnPadLengths[i], { pad: StringPrototypePadStart })), kSeparator)}${kSeparator}` +
`${getCell('uncovered lines', uncoveredLinesPadLength, { truncate: truncateEnd })}\n`;
report += `${prefix}${getCell('file', filePadLength, StringPrototypePadEnd, truncateEnd)}${kSeparator}` +
`${ArrayPrototypeJoin(ArrayPrototypeMap(kColumns, (column, i) => getCell(column, columnPadLengths[i], StringPrototypePadStart)), kSeparator)}${kSeparator}` +
`${getCell('uncovered lines', uncoveredLinesPadLength, false, truncateEnd)}\n`;
if (table) report += addTableLine(prefix, tableWidth);

// Body
Expand All @@ -392,15 +392,15 @@ function getCoverageReport(pad, summary, symbol, color, table) {
});
fileCoverage /= kColumnsKeys.length;

report += `${prefix}${getCell(relativePath, filePadLength, { pad: StringPrototypePadEnd, truncate: truncateStart, coverage: fileCoverage })}${kSeparator}` +
`${ArrayPrototypeJoin(ArrayPrototypeMap(coverages, (coverage, j) => getCell(NumberPrototypeToFixed(coverage, 2), columnPadLengths[j], { coverage, pad: StringPrototypePadStart })), kSeparator)}${kSeparator}` +
`${getCell(formatUncoveredLines(file.uncoveredLineNumbers, table), uncoveredLinesPadLength, { truncate: truncateEnd })}\n`;
report += `${prefix}${getCell(relativePath, filePadLength, StringPrototypePadEnd, truncateStart, fileCoverage)}${kSeparator}` +
`${ArrayPrototypeJoin(ArrayPrototypeMap(coverages, (coverage, j) => getCell(NumberPrototypeToFixed(coverage, 2), columnPadLengths[j], StringPrototypePadStart, false, coverage)), kSeparator)}${kSeparator}` +
`${getCell(formatUncoveredLines(file.uncoveredLineNumbers, table), uncoveredLinesPadLength, false, truncateEnd)}\n`;
}

// Foot
if (table) report += addTableLine(prefix, tableWidth);
report += `${prefix}${getCell('all files', filePadLength, { pad: StringPrototypePadEnd, truncate: truncateEnd })}${kSeparator}` +
`${ArrayPrototypeJoin(ArrayPrototypeMap(kColumnsKeys, (columnKey, j) => getCell(NumberPrototypeToFixed(summary.totals[columnKey], 2), columnPadLengths[j], { coverage: summary.totals[columnKey], pad: StringPrototypePadStart })), kSeparator)} |\n`;
report += `${prefix}${getCell('all files', filePadLength, StringPrototypePadEnd, truncateEnd)}${kSeparator}` +
`${ArrayPrototypeJoin(ArrayPrototypeMap(kColumnsKeys, (columnKey, j) => getCell(NumberPrototypeToFixed(summary.totals[columnKey], 2), columnPadLengths[j], StringPrototypePadStart, false, summary.totals[columnKey])), kSeparator)} |\n`;
if (table) report += addTableLine(prefix, tableWidth);

report += `${prefix}end of coverage report\n`;
Expand Down