Skip to content

Enable Node.js to run with Microsoft's ChakraCore engine #4765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kunalspathak wants to merge 9 commits into from
Closed

Enable Node.js to run with Microsoft's ChakraCore engine #4765

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
77a5f8d
chakrashim: implement V8 APIs on Chakra
kunalspathak Jan 12, 2016
8a8c98c
deps: chakracore source code
kunalspathak Jan 12, 2016
b6e81a2
build: build with chakrashim/chakracore
kunalspathak Jan 28, 2016
81fb6d5
node-gyp: Support to build with chakracore engine
kunalspathak Jan 28, 2016
c1ae676
gyp: Support to build with chakracore engine
kunalspathak Jan 28, 2016
6e97a0b
node-gyp: Support to build with chakracore for ARM
kunalspathak Jan 28, 2016
432d4a9
gyp: Support to build with chakracore for ARM
kunalspathak Jan 28, 2016
abccd71
src,lib: Node source changes for Chakra engine
kunalspathak Jan 12, 2016
19b2e48
test: Fixed unittest for Chakra engine
kunalspathak Jan 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gyp: Support to build with chakracore engine 
Add support to allow node.js build with chakracore enigne for Windows OS
x86/x64 architecture.

* Configure msvs_use_library_dependency_inputs to export symbols
   correctly (otherwise functions not used by node.exe but might be
   needed by native addon modules could be optimized away by linker).
  • Loading branch information
@kunalspathak
kunalspathak committed Jan 28, 2016
commit c1ae6762f1fb582970dbc3a932b97acab09f2f1e
5 changes: 5 additions & 0 deletions tools/gyp/pylib/gyp/generator/msvs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,8 @@ def _BuildCommandLineForRuleRaw(spec, cmd, cygwin_shell, has_input_path,
command = ['type']
else:
command = [cmd[0].replace('/', '\\')]
if quote_cmd:
command = ['"%s"' % i for i in command]
# Add call before command to ensure that commands can be tied together one
# after the other without aborting in Incredibuild, since IB makes a bat
# file out of the raw command string, and some commands (like python) are
Expand Down Expand Up @@ -3203,6 +3205,9 @@ def _GetMSBuildProjectReferences(project):
['ReferenceOutputAssembly', 'false']
]
for config in dependency.spec.get('configurations', {}).itervalues():
if config.get('msvs_use_library_dependency_inputs', 0):
project_ref.append(['UseLibraryDependencyInputs', 'true'])
break
# If it's disabled in any config, turn it off in the reference.
if config.get('msvs_2010_disable_uldi_when_referenced', 0):
project_ref.append(['UseLibraryDependencyInputs', 'false'])
Expand Down