Skip to content

sea: add option to disable the experimental SEA warning #47588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 26 commits into from
May 4, 2023
Merged

sea: add option to disable the experimental SEA warning #47588

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
4b66620
sea: add option to disable the experimental SEA warning
RaisinTen Apr 14, 2023
e69de9f
src: use string_views in JSONParser
RaisinTen Apr 18, 2023
ec57d90
src: proper Maybe usage in JSONParser
RaisinTen Apr 18, 2023
4442309
src: add TODO for adding support for non-ASCII encoded string fields
RaisinTen Apr 18, 2023
f49d7ef
doc: use `disableExperimentalSEAWarning` in SEA example
RaisinTen Apr 24, 2023
ec0cdd6
sea: use a uint32_t bit field instead of bool disable_experimental_se…
RaisinTen Apr 25, 2023
a4af172
sea: use std::bitset instead of uint32_t
RaisinTen Apr 25, 2023
41669e4
fixup! sea: use std::bitset instead of uint32_t
RaisinTen Apr 25, 2023
2fd9f9a
fixup! fixup! sea: use std::bitset instead of uint32_t
RaisinTen Apr 25, 2023
8bb2fed
sea: use the SeaFlags enum class instead of std::bitset
RaisinTen Apr 26, 2023
457dfcd
sea: move flags before code in SeaResource struct
RaisinTen Apr 26, 2023
ff0a9c7
sea: expose only isExperimentalSeaWarningNeeded to JS from the binding
RaisinTen Apr 26, 2023
8d67348
doc: omit false option from disableExperimentalSEAWarning doc
RaisinTen Apr 26, 2023
5096a28
doc: omit disableExperimentalSEAWarning from the summary
RaisinTen Apr 26, 2023
5ce2126
fixup! sea: expose only isExperimentalSeaWarningNeeded to JS from the…
RaisinTen Apr 26, 2023
0ff4075
sea: check IsSingleExecutable value before calling FindSingleExecutab…
RaisinTen Apr 27, 2023
305b7a6
src: support UTF8 fields in JSONParser
RaisinTen Apr 27, 2023
c2da60b
src: do proper Maybe usage
RaisinTen Apr 27, 2023
eb858c1
test: move single executable E2E tests to sequential
RaisinTen Apr 27, 2023
b3f437a
test: convert the SEA skips into a helper in test/common
RaisinTen Apr 28, 2023
83f996b
fixup! test: convert the SEA skips into a helper in test/common
RaisinTen Apr 28, 2023
5d21e60
Revert "src: do proper Maybe usage"
RaisinTen Apr 29, 2023
009fe2f
src: define kHeaderSize and use it everywhere
RaisinTen May 3, 2023
d6642b7
test: wrap inject + code signing part into a helper
RaisinTen May 3, 2023
3373bd5
fixup! test: wrap inject + code signing part into a helper
RaisinTen May 3, 2023
2b5804e
fixup! src: define kHeaderSize and use it everywhere
RaisinTen May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: define kHeaderSize and use it everywhere 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
  • Loading branch information
@RaisinTen
RaisinTen committed May 3, 2023
commit 2b5804ee0199d8300bc07f33813439a39676c32e
9 changes: 4 additions & 5 deletions src/node_sea.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,9 @@ SeaFlags operator|=(/* NOLINT (runtime/references) */ SeaFlags& x, SeaFlags y) {
struct SeaResource {
SeaFlags flags = SeaFlags::kDefault;
std::string_view code;
Comment thread
RaisinTen marked this conversation as resolved.
static constexpr size_t kHeaderSize = sizeof(kMagic) + sizeof(SeaFlags);
};

constexpr size_t kHeaderSize = sizeof(kMagic) + sizeof(SeaFlags);

SeaResource FindSingleExecutableResource() {
CHECK(IsSingleExecutable());
static const SeaResource sea_resource = []() -> SeaResource {
Expand All @@ -88,8 +87,8 @@ SeaResource FindSingleExecutableResource() {
return {
flags,
{
code + kHeaderSize,
size - kHeaderSize,
code + SeaResource::kHeaderSize,
size - SeaResource::kHeaderSize,
},
};
}();
Expand Down Expand Up @@ -207,7 +206,7 @@ bool GenerateSingleExecutableBlob(const SeaConfig& config) {

std::vector<char> sink;
// TODO(joyeecheung): reuse the SnapshotSerializerDeserializer for this.
sink.reserve(kHeaderSize + main_script.size());
sink.reserve(SeaResource::kHeaderSize + main_script.size());
const char* pos = reinterpret_cast<const char*>(&kMagic);
sink.insert(sink.end(), pos, pos + sizeof(kMagic));
pos = reinterpret_cast<const char*>(&(config.flags));
Expand Down