Skip to content

test_runner: execute before hook on test #47586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Apr 18, 2023
Merged

test_runner: execute before hook on test #47586

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e09df4
test_runner: execute before hook on test
atlowChemi Apr 14, 2023
013a47d
add test & fix lint
atlowChemi Apr 16, 2023
80ddbaf
fix doc
atlowChemi Apr 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test & fix lint
  • Loading branch information
@atlowChemi
atlowChemi committed Apr 16, 2023
commit 013a47d4de692a5f84cf2031dcbb3956bd69091b
3 changes: 1 addition & 2 deletions doc/api/test.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1501,7 +1501,7 @@ added:
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/47586
description: The `before` function was added to TestContext
description: The `before` function was added to TestContext.
-->

An instance of `TestContext` is passed to each test function in order to
Expand All @@ -1528,7 +1528,6 @@ added: REPLACEME
This function is used to create a hook running before running a suite.
before subtest of the current test.


### `context.beforeEach([fn][, options])`

<!-- YAML
Expand Down
4 changes: 4 additions & 0 deletions test/fixtures/test-runner/output/hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ const common = require('../../../common');
const assert = require('assert');
const { test, describe, it, before, after, beforeEach, afterEach } = require('node:test');

before((t) => t.diagnostic('before 1 called'));

describe('describe hooks', () => {
const testArr = [];
before(function() {
Expand Down Expand Up @@ -157,3 +159,5 @@ test('t.after() is called if test body throws', (t) => {
});
throw new Error('bye');
});

before((t) => t.diagnostic('before 2 called'));
7 changes: 2 additions & 5 deletions test/fixtures/test-runner/output/hooks.snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,6 @@ not ok 11 - t.afterEach throws
*
*
*
*
...
# Subtest: 2
ok 2 - 2
Expand Down Expand Up @@ -500,7 +499,6 @@ not ok 12 - afterEach when test fails
*
*
*
*
...
# Subtest: 2
not ok 2 - 2
Expand Down Expand Up @@ -541,12 +539,11 @@ not ok 14 - t.after() is called if test body throws
*
*
*
*
*
*
...
# - after() called
1..14
# before 1 called
# before 2 called
# tests 38
# suites 8
# pass 14
Expand Down