Skip to content

[v19.x] src: bootstrap Web [Exposed=*] APIs in the shadow realm #47530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
legendecas wants to merge 3 commits into from
Closed

[v19.x] src: bootstrap Web [Exposed=*] APIs in the shadow realm #47530

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4fb8da
lib: distinguish webidl interfaces with the extended property "Exposed"
legendecas Mar 15, 2023
57956d6
src: bootstrap Web [Exposed=*] APIs in the shadow realm
legendecas Mar 15, 2023
7c77f71
test: move test-shadow-realm-gc.js to known_issues
joyeecheung Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: move test-shadow-realm-gc.js to known_issues 
There is actually a leak. The test doesn't exercise the right
path to create a substantial enough object graph (e.g.
accessing something that results in the loading of a binding).
This does something more complicated in the test and moves it
to known_issues until we find a fix.

PR-URL: #47355
Refs: #47353
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
  • Loading branch information
@joyeecheung @legendecas
joyeecheung authored and legendecas committed Apr 12, 2023
commit 7c77f71e76da72c13a88ce1c886f24be3b7cf2b9
3 changes: 3 additions & 0 deletions test/known_issues/known_issues.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ prefix known_issues
# foreseeable future. The test itself is flaky and skipped. It
# serves as a demonstration of the issue only.
test-vm-timeout-escape-queuemicrotask: SKIP
# Skipping it because it crashes out of OOM instead of exiting.
# https://github.com/nodejs/node/issues/47353
test-shadow-realm-gc: SKIP

[$system==win32]

Expand Down
3 changes: 2 additions & 1 deletion test/parallel/test-shadow-realm-gc.js → test/known_issues/test-shadow-realm-gc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@
require('../common');

for (let i = 0; i < 1000; i++) {
new ShadowRealm();
const realm = new ShadowRealm();
realm.evaluate('new TextEncoder(); 1;');
}