Skip to content

test: verify tracePromise does not do runStores #47349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Apr 3, 2023
Merged

test: verify tracePromise does not do runStores #47349

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b1ec5c
test: verify tracePromise does not do runStores
Mar 31, 2023
e9a2667
Update test/parallel/test-diagnostics-channel-tracing-channel-promise…
Qard Apr 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: verify tracePromise does not do runStores
  • Loading branch information
Stephen Belanger committed Mar 31, 2023
commit 5b1ec5cb2ac36508d4d51985e792d2f85cea739d
15 changes: 11 additions & 4 deletions test/parallel/test-diagnostics-channel-tracing-channel-promise-run-stores.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,23 @@ const assert = require('assert');
const channel = dc.tracingChannel('test');
const store = new AsyncLocalStorage();

const context = { foo: 'bar' };
const firstContext = { foo: 'bar' };
const secondContext = { baz: 'buz' };

channel.start.bindStore(store, common.mustCall(() => {
return context;
return firstContext;
}));

channel.asyncStart.bindStore(store, common.mustNotCall(() => {
return secondContext;
}));

assert.strictEqual(store.getStore(), undefined);
channel.tracePromise(common.mustCall(async () => {
assert.deepStrictEqual(store.getStore(), context);
assert.deepStrictEqual(store.getStore(), firstContext);
await setTimeout(1);
assert.deepStrictEqual(store.getStore(), context);
// Should _not_ switch to second context as promises don't have an "afer"
Comment thread
Qard marked this conversation as resolved.
Outdated
// point at which to do a runStores.
assert.deepStrictEqual(store.getStore(), firstContext);
}));
assert.strictEqual(store.getStore(), undefined);