Skip to content

doc: fix incorrect links #47089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Robot-dev11 wants to merge 2 commits into from
Closed

doc: fix incorrect links #47089

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b8a8e9
doc: fix incorrect links
Mar 14, 2023
7de1997
doc: fix incorrect links
Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
doc: fix incorrect links 
Revert changes of process.md and worker_threads.md
Fixes: #47070
  • Loading branch information
Giriraj Soni authored and Giriraj Soni committed Mar 15, 2023
commit 7de199710c8baad26dab6c7cce5f11dd3c0e53b0
2 changes: 1 addition & 1 deletion doc/api/process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3975,7 +3975,7 @@ cases:
[`process.config`]: #processconfig
[`process.execPath`]: #processexecpath
[`process.exit()`]: #processexitcode
[`process.exitCode`]: #processexitcode-1
[`process.exitCode`]: #processexitcode_1
[`process.hrtime()`]: #processhrtimetime
[`process.hrtime.bigint()`]: #processhrtimebigint
[`process.kill()`]: #processkillpid-signal
Expand Down
4 changes: 2 additions & 2 deletions doc/api/worker_threads.md
View file
Open in desktop
Copy link
Copy Markdown
Member

@debadree25 debadree25 Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the changes in this file are not required, these changes are making the workflow fail, I tested locally. you can test it locally too by running make doc and check any failures

Original file line number Diff line number Diff line change
Expand Up @@ -1398,10 +1398,10 @@ thread spawned will spawn another until the application crashes.
[`v8.getHeapSnapshot()`]: v8.md#v8getheapsnapshotoptions
[`vm`]: vm.md
[`worker.SHARE_ENV`]: #workershare_env
[`worker.on('message')`]: #event-message-1
[`worker.on('message')`]: #event-message_1
[`worker.postMessage()`]: #workerpostmessagevalue-transferlist
[`worker.terminate()`]: #workerterminate
[`worker.threadId`]: #workerthreadid-1
[`worker.threadId`]: #workerthreadid_1
[async-resource-worker-pool]: async_context.md#using-asyncresource-for-a-worker-thread-pool
[browser `MessagePort`]: https://developer.mozilla.org/en-US/docs/Web/API/MessagePort
[child processes]: child_process.md
Expand Down