fixup! remove breaking change

nodejs · nodejs-github-bot · Mar 6, 2023 · Feb 25, 2023 · Feb 26, 2023 · Feb 26, 2023
commit 35811f5f59ffbef2b22e932be60b4b9efa92b62c
diff --git a/src/api/environment.cc b/src/api/environment.cc
@@ -505,6 +505,20 @@ void FreeEnvironment(Environment* env) {
   delete env;
 }
 
+NODE_EXTERN std::unique_ptr<InspectorParentHandle> GetInspectorParentHandle(
+    Environment* env,
+    ThreadId thread_id,
+    const char* url) {
+  CHECK_NOT_NULL(env);
+  CHECK_NE(thread_id.id, static_cast<uint64_t>(-1));
+#if HAVE_INSPECTOR
+  return std::make_unique<InspectorParentHandleImpl>(
+      env->inspector_agent()->GetParentHandle(thread_id.id, url, ""));
+#else
+  return {};
+#endif
+}
+
 NODE_EXTERN std::unique_ptr<InspectorParentHandle> GetInspectorParentHandle(
     Environment* env,
     ThreadId thread_id,

diff --git a/src/node.h b/src/node.h
@@ -674,6 +674,11 @@ NODE_EXTERN Environment* CreateEnvironment(
 // Environment, together with the inspector handle.
 // This method should not be called while the parent Environment is active
 // on another thread.
+NODE_EXTERN std::unique_ptr<InspectorParentHandle> GetInspectorParentHandle(
+    Environment* parent_env,
+    ThreadId child_thread_id,
+    const char* child_url);
+
 NODE_EXTERN std::unique_ptr<InspectorParentHandle> GetInspectorParentHandle(
     Environment* parent_env,
     ThreadId child_thread_id,

diff --git a/test/cctest/test_environment.cc b/test/cctest/test_environment.cc
@@ -449,7 +449,7 @@ TEST_F(EnvironmentTest, InspectorMultipleEmbeddedEnvironments) {
   ChildEnvironmentData data;
   data.thread_id = node::AllocateEnvironmentThreadId();
   data.inspector_parent_handle =
-      GetInspectorParentHandle(*env, data.thread_id, "file:///embedded.js", "");
+      GetInspectorParentHandle(*env, data.thread_id, "file:///embedded.js");
   CHECK(data.inspector_parent_handle);
   data.platform = GetMultiIsolatePlatform(*env);
   CHECK_NOT_NULL(data.platform);