Skip to content

lib: remove unused modules #4683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 15 commits into from
Closed

lib: remove unused modules #4683

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
31b6580
tools: implement no-unused-vars for eslint
Trott Dec 23, 2015
54e4c09
doc: fix numbering in stream.markdown
richardsun29 Jan 5, 2016
5d6e1c2
doc: bring releases.md up to date
cjihrig Jan 5, 2016
8cb8840
doc: add missing backtick for readline
mscdex Jan 6, 2016
719b145
doc: add Myles Borins to Release Team
Jan 8, 2016
a28e51a
doc: add Evan Lucas to Release Team
evanlucas Jan 8, 2016
5143719
doc: fix description about the latest-codename
JungMinu Jan 8, 2016
367a13d
doc: label http.IncomingMessage as a Class
Sequoia Jan 8, 2016
80ad952
doc: document http's server.listen return value
Sequoia Jan 8, 2016
d9768a4
doc: adds usage of readline line-by-line parsing
eljefedelrodeodeljefe Jan 10, 2016
47e8395
doc: update stylesheet to match frontpage
silverwind Jan 11, 2016
500477c
doc: add branch-diff example to releases.md
Jan 12, 2016
ed427a6
docs: fix npm command in releases.md
Jan 13, 2016
2192fc8
docs: update gpg key for Myles Borins
Jan 13, 2016
4236bc2
lib: remove unused modules
Trott Dec 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: add branch-diff example to releases.md 
Useful to have for reference, especially for onboarding

PR-URL: #4636
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell<jasnell@gmail.com>
  • Loading branch information
Myles Borins committed Jan 13, 2016
commit 500477c3a98c4fc9e4a713f90122991a715fa412
6 changes: 6 additions & 0 deletions doc/releases.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ Notes:

Create a new branch named _"vx.y.z-proposal"_, or something similar. Using `git cherry-pick`, bring the appropriate commits into your new branch. To determine the relevant commits, use [`branch-diff`](https://github.com/rvagg/branch-diff) and [`changelog-maker`](https://github.com/rvagg/changelog-maker/) (both are available on npm and should be installed globally). These tools depend on our commit metadata, as well as the `semver-minor` and `semver-major` GitHub labels. One drawback is that when the `PR-URL` metadata is accidentally omitted from a commit, the commit will show up because it's unsure if it's a duplicate or not.

For a list of commits that could be landed in a patch release on v5.x

```
$ branch-diff v5.x master --exclude-label semver-major,semver-minor,dont-land-on-v5.x --simple
```

Carefully review the list of commits looking for errors (incorrect `PR-URL`, incorrect semver, etc.). Commits labeled as semver minor or semver major should only be cherry-picked when appropriate for the type of release being made. Previous release commits and version bumps do not need to be cherry-picked.

### 2. Update `src/node_version.h`
Expand Down