Skip to content

Revert commits that cause failing tests on Windows CI #4679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

Revert commits that cause failing tests on Windows CI #4679

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c6c0f3
fs: revert "change statSync to accessSync..."
Trott Jan 13, 2016
9c4c63b
module: revert "optimize js and json file i/o"
Trott Jan 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
module: revert "optimize js and json file i/o" 
This reverts commit 7c60328.

It is causing CI failures on Windows.

Ref: #4575
PR-URL: #4679
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
@Trott
Trott committed Jan 15, 2016
commit 9c4c63bfdbc7a428560a0c48168cb4437e1425ba
4 changes: 2 additions & 2 deletions lib/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,14 +428,14 @@ Module.prototype._compile = function(content, filename) {

// Native extension for .js
Module._extensions['.js'] = function(module, filename) {
var content = internalModuleReadFile(filename);
var content = fs.readFileSync(filename, 'utf8');
module._compile(internalModule.stripBOM(content), filename);
};


// Native extension for .json
Module._extensions['.json'] = function(module, filename) {
var content = internalModuleReadFile(filename);
var content = fs.readFileSync(filename, 'utf8');
try {
module.exports = JSON.parse(internalModule.stripBOM(content));
} catch (err) {
Expand Down