Skip to content

http: use listenerCount when adding noop event #46769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
Mar 8, 2023
+67 −1
Merged

http: use listenerCount when adding noop event #46769

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
56693fe
http: use listenerCount when adding noop event
ShogunPanda Feb 22, 2023
ff212f7
http: also warn the user when preventing the leak
ShogunPanda Feb 23, 2023
196ec78
net: fix error message
ShogunPanda Feb 27, 2023
de99a80
http: remove useless test
ShogunPanda Mar 5, 2023
e9b3a8d
http: linted code
ShogunPanda Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
http: remove useless test
  • Loading branch information
@ShogunPanda
ShogunPanda committed Mar 5, 2023
commit de99a80bc161f1279f989d4cf31fabb995db88cb
36 changes: 0 additions & 36 deletions test/parallel/test-http-socket-error-listeners.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,39 +46,3 @@ const net = require('net');
});
}

{
const valid = 'GET / HTTP/1.1\r\nHost:a\r\nContent-Length:1\r\n\r\n1\r\n';

const server = http.createServer((req, res) => {
const handler = common.mustCall(function handler(error) {
req.socket.removeListener('error', handler);
}, 2);

req.on('end', handler);
req.socket.on('error', handler);

res.removeHeader('date');
res.writeHead(204);
res.end();
});

server.listen(0, () => {
const client = net.createConnection({ host: '127.0.0.1', port: server.address().port });
let data = Buffer.alloc(0);

client.on('data', (chunk) => {
data = Buffer.concat([data, chunk]);
});

client.on('end', () => {
assert.strictEqual(
data.toString('utf-8'),
'HTTP/1.1 204 No Content\r\nConnection: keep-alive\r\nKeep-Alive: timeout=5\r\n\r\n' +
'HTTP/1.1 400 Bad Request\r\nConnection: close\r\n\r\n',
);
server.close();
});

client.write(valid + 'INVALID');
});
}