Skip to content

repl: fix .load infinite loop caused by shared use of lineEnding RegExp #46742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 12 commits into from
Mar 1, 2023
+46 −9
Merged

repl: fix .load infinite loop caused by shared use of lineEnding RegExp #46742

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2b0871d
repl: fix .load infinite loop caused by shared use of lineEnding RegExp
Theo-Steiner Feb 20, 2023
f5c3190
test: add test that fails without the changes of #46742
Theo-Steiner Feb 27, 2023
a9010dc
chore: remove unrelated comment
Theo-Steiner Feb 27, 2023
6797e75
chore: fix linting errors and rename test
Theo-Steiner Feb 27, 2023
ba29072
remove magic number from test
Theo-Steiner Feb 28, 2023
ced5097
fix: refactor to use module scope instance of RegExp safely for perfo…
Theo-Steiner Feb 28, 2023
24a0fb6
chore: fix linting errors
Theo-Steiner Feb 28, 2023
d002103
docs: update comments
Theo-Steiner Feb 28, 2023
1cc6e4e
chore: make finishing touches on comments
Theo-Steiner Feb 28, 2023
6699359
test: fix test failing due to difference in terminal codes
Theo-Steiner Mar 1, 2023
d8d6375
Revert "test: fix test failing due to difference in terminal codes"
Theo-Steiner Mar 1, 2023
3950542
fix: erase lastIndex state for previous searches
Theo-Steiner Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: erase lastIndex state for previous searches
  • Loading branch information
@Theo-Steiner
Theo-Steiner committed Mar 1, 2023
commit 395054215dc3b053a17ae3955a8cb4902940ad0e
2 changes: 2 additions & 0 deletions lib/internal/readline/interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1322,6 +1322,8 @@ class Interface extends InterfaceConstructor {
// falls through
default:
if (typeof s === 'string' && s) {
// Erase state of previous searches.
lineEnding.lastIndex = 0;
let nextMatch = RegExpPrototypeExec(lineEnding, s);
// If no line endings are found, just insert the string as is.
if (nextMatch === null) {
Expand Down