Skip to content

test: fix assertions in test-snapshot-dns-lookup* #46618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Feb 18, 2023
Merged

test: fix assertions in test-snapshot-dns-lookup* #46618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix assertions in test-snapshot-dns-lookup* 
Due to the unfortunate nature of JavaScript, the extraneous arguments
are silently ignored. In this case, the assertion trivially passes
regardless of the given regular expressions.

Refs: #44633
  • Loading branch information
@tniessen
tniessen committed Feb 11, 2023
commit 765de7ecd3115abbf4cb64f80f984f1e610c235c
4 changes: 2 additions & 2 deletions test/internet/test-snapshot-dns-lookup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ const env = {

tmpdir.refresh();
function checkOutput(stderr, stdout) {
assert(stdout.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/));
assert(stdout.match(stdout, /family: 4/));
assert.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/);
assert.match(stdout, /family: 4/);
assert.strictEqual(stdout.trim().split('\n').length, 2);
}
{
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-snapshot-dns-lookup-localhost-promise.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ function checkOutput(stderr, stdout) {
// We allow failures as it's not always possible to resolve localhost.
// Functional tests are done in test/internet instead.
if (!stderr.startsWith('error:')) {
assert(stdout.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/));
assert(stdout.match(stdout, /family: 4/));
assert.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/);
assert.match(stdout, /family: 4/);
assert.strictEqual(stdout.trim().split('\n').length, 2);
}
}
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-snapshot-dns-lookup-localhost.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ function checkOutput(stderr, stdout) {
// We allow failures as it's not always possible to resolve localhost.
// Functional tests are done in test/internet instead.
if (!stderr.startsWith('error:')) {
assert(stdout.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/));
assert(stdout.match(stdout, /family: 4/));
assert.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/);
assert.match(stdout, /family: 4/);
assert.strictEqual(stdout.trim().split('\n').length, 2);
}
}
Expand Down