Skip to content

src: fix negative nodeTiming milestone values #46588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
legendecas wants to merge 2 commits into from
Closed

src: fix negative nodeTiming milestone values #46588

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6760c9a
src: fix negative nodeTiming milestone values
legendecas Feb 9, 2023
c9e94f6
fixup! fix tools/run-worker.js failure
legendecas Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fix tools/run-worker.js failure
  • Loading branch information
@legendecas
legendecas committed Feb 27, 2023
commit c9e94f6d69db38e52819fe438c31c4196d4f11de
9 changes: 8 additions & 1 deletion test/parallel/test-performance-nodetiming.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
const common = require('../common');
const assert = require('assert');
const { performance } = require('perf_hooks');
const { isMainThread } = require('worker_threads');

const { nodeTiming } = performance;
assert.strictEqual(nodeTiming.name, 'node');
Expand All @@ -24,7 +25,13 @@ for (let idx = 0; idx < keys.length; idx++) {

// loop milestones.
assert.strictEqual(nodeTiming.idleTime, 0);
assert.strictEqual(nodeTiming.loopStart, -1);
if (isMainThread) {
// Main thread does not start loop until the first tick is finished.
assert.strictEqual(nodeTiming.loopStart, -1);
} else {
// Worker threads run the user script after loop is started.
assert.ok(nodeTiming.loopStart >= nodeTiming.bootstrapComplete);
}
assert.strictEqual(nodeTiming.loopExit, -1);

setTimeout(common.mustCall(() => {
Expand Down