Skip to content

test_runner: emit test-only diagnostic warning #46540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Feb 21, 2023
Merged

test_runner: emit test-only diagnostic warning #46540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test_runner: emit test-only diagnostic warning
  • Loading branch information
@richiemccoll
richiemccoll committed Feb 20, 2023
commit 7696218807bf58b7a062b6cbf10cd799d896e6ed
6 changes: 6 additions & 0 deletions lib/internal/test_runner/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,12 @@ class Test extends AsyncResource {
};
this.waitingOn = 0;
this.finished = false;

if (!testOnlyFlag && (only || this.runOnlySubtests)) {
Comment thread
richiemccoll marked this conversation as resolved.
const warning =
"'only' and 'runOnly' require the --test-only command-line option.";
this.diagnostic(warning);
}
}

hasConcurrency() {
Expand Down
3 changes: 3 additions & 0 deletions test/message/test_runner_output.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,11 +475,13 @@ ok 52 - callback async throw after done
---
duration_ms: *
...
# 'only' and 'runOnly' require the --test-only command-line option.
# Subtest: running subtest 3
ok 3 - running subtest 3
---
duration_ms: *
...
# 'only' and 'runOnly' require the --test-only command-line option.
# Subtest: running subtest 4
ok 4 - running subtest 4
---
Expand All @@ -490,6 +492,7 @@ ok 53 - only is set but not in only mode
---
duration_ms: *
...
# 'only' and 'runOnly' require the --test-only command-line option.
# Subtest: custom inspect symbol fail
not ok 54 - custom inspect symbol fail
---
Expand Down
3 changes: 3 additions & 0 deletions test/message/test_runner_output_cli.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,11 +475,13 @@ ok 52 - callback async throw after done
---
duration_ms: *
...
# 'only' and 'runOnly' require the --test-only command-line option.
# Subtest: running subtest 3
ok 3 - running subtest 3
---
duration_ms: *
...
# 'only' and 'runOnly' require the --test-only command-line option.
# Subtest: running subtest 4
ok 4 - running subtest 4
---
Expand All @@ -490,6 +492,7 @@ ok 53 - only is set but not in only mode
---
duration_ms: *
...
# 'only' and 'runOnly' require the --test-only command-line option.
# Subtest: custom inspect symbol fail
not ok 54 - custom inspect symbol fail
---
Expand Down
3 changes: 3 additions & 0 deletions test/message/test_runner_output_spec_reporter.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,12 @@
only is set but not in only mode
running subtest 1 (*ms)
running subtest 2 (*ms)
'only' and 'runOnly' require the --test-only command-line option.
running subtest 3 (*ms)
'only' and 'runOnly' require the --test-only command-line option.
running subtest 4 (*ms)
only is set but not in only mode (*ms)
'only' and 'runOnly' require the --test-only command-line option.

custom inspect symbol fail (*ms)
customized
Expand Down