Skip to content

test_runner: top-level diagnostics not ommited when running with --test #46441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Feb 2, 2023
Merged

test_runner: top-level diagnostics not ommited when running with --test #46441

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
de70efa
test_runner: top-level diagnostics not ommited when running with --test
pulkit-30 Jan 31, 2023
bb83008
remove redundant test
pulkit-30 Jan 31, 2023
d3ab0fc
used StringPrototypeSplit primordials and added more conditions
pulkit-30 Jan 31, 2023
754e8d3
move StringPrototypeSplit up a line and rename variable
pulkit-30 Jan 31, 2023
7719a4b
used StringPrototypeIndexOf in place of StringPrototypeSplit primordials
pulkit-30 Jan 31, 2023
6671519
added condition to firstSpaceIndex
pulkit-30 Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
used StringPrototypeIndexOf in place of StringPrototypeSplit primordials
  • Loading branch information
@pulkit-30
pulkit-30 committed Jan 31, 2023
commit 7719a4b7b373b07766044027242239cb796037b9
11 changes: 7 additions & 4 deletions lib/internal/test_runner/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ const {
SafePromiseAllSettledReturnVoid,
SafeMap,
SafeSet,
StringPrototypeSplit,
StringPrototypeIndexOf,
StringPrototypeSlice,
StringPrototypeStartsWith,
} = primordials;

Expand Down Expand Up @@ -132,9 +133,11 @@ function getRunArgs({ path, inspectPort }) {

class FileTest extends Test {
#buffer = [];
#checkNestedComment(node) {
const commentArgs = StringPrototypeSplit(node.comment, ' ');
return commentArgs.length === 2 && ArrayPrototypeIncludes(kDiagnosticsFilterArgs, commentArgs[0]);
#checkNestedComment({ comment }) {
const firstSpaceIndex = StringPrototypeIndexOf(comment, ' ');
Comment thread
aduh95 marked this conversation as resolved.
const secondSpaceIndex = StringPrototypeIndexOf(comment, ' ', firstSpaceIndex + 1);
return secondSpaceIndex === -1 &&
ArrayPrototypeIncludes(kDiagnosticsFilterArgs, StringPrototypeSlice(comment, 0, firstSpaceIndex));
}
#handleReportItem({ kind, node, nesting = 0 }) {
nesting += 1;
Expand Down