Skip to content

test_runner: flatten TAP output when running using --test #46440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Feb 18, 2023
Merged

test_runner: flatten TAP output when running using --test #46440

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd1e3ba
test_runner: flatten TAP output when running using `--test`
MoLow Jan 31, 2023
a1f6e9e
CR
MoLow Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
CR
  • Loading branch information
@MoLow
MoLow committed Feb 17, 2023
commit a1f6e9e00bedc2cd4d32a32499185ba0fe32b4f2
6 changes: 4 additions & 2 deletions lib/internal/test_runner/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const {
ArrayPrototypeSlice,
ArrayPrototypeSome,
ArrayPrototypeSort,
FunctionPrototypeCall,
Number,
ObjectAssign,
ObjectKeys,
Expand Down Expand Up @@ -197,8 +198,9 @@ class FileTest extends Test {
const method = pass ? 'ok' : 'fail';
this.reporter[method](nesting, this.name, testNumber, node.description, diagnostics, directive);
if (nesting === 0) {
super.countSubtest
.call({ finished: true, skipped: skip, isTodo: todo, passed: pass, cancelled }, this.#counters);
FunctionPrototypeCall(super.countSubtest,
{ finished: true, skipped: skip, isTodo: todo, passed: pass, cancelled },
this.#counters);
this.failedSubtests ||= !pass;
}
break;
Expand Down