Skip to content

[v18.x] backport startup performance patches #46425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 13 commits into from
Closed

[v18.x] backport startup performance patches #46425

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
10f5974
bootstrap: lazy-load Performance.prototype.timeOrigin
joyeecheung Jan 30, 2023
3076119
test: use an array for WPT gloablThis initialization scripts
joyeecheung Jan 30, 2023
9960b3d
bootstrap: lazy load non-essential modules
joyeecheung Dec 9, 2022
a73d729
bootstrap: support module_wrap binding in snapshot
joyeecheung Dec 13, 2022
1892b8d
bootstrap: include event_target into the built-in snapshot
joyeecheung Dec 13, 2022
4a6a473
modules: move modules/cjs/helpers.js to modules/helpers.js
joyeecheung Dec 13, 2022
92c4600
lib: add getLazy() method to internal/util
joyeecheung Dec 13, 2022
9a9a5b5
lib: lazy-load deps in source_map_cache.js
joyeecheung Dec 13, 2022
ce5f49e
lib: lazy-load deps in modules/run_main.js
joyeecheung Dec 13, 2022
9ea0ae4
modules: move callbacks and conditions into modules/esm/utils.js
joyeecheung Dec 13, 2022
5060fd2
bootstrap: make CJS loader snapshotable
joyeecheung Dec 13, 2022
6c1abed
bootstrap: optimize modules loaded in the built-in snapshot
joyeecheung Dec 13, 2022
bfa6a2e
deps: V8: cherry-pick d69c7937c99d
targos Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bootstrap: lazy-load Performance.prototype.timeOrigin
  • Loading branch information
@joyeecheung @targos
joyeecheung authored and targos committed Oct 28, 2023
commit 10f5974fac05c98979f2cb38843296b865035754
29 changes: 14 additions & 15 deletions lib/internal/perf/performance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,15 +206,24 @@ ObjectDefineProperties(Performance.prototype, {
enumerable: false,
value: timerify,
},
// This would be updated during pre-execution in case
// the process is launched from a snapshot.
// TODO(joyeecheung): we may want to warn about access to
// this during snapshot building.
timeOrigin: {
__proto__: null,
configurable: true,
enumerable: true,
value: getTimeOriginTimestamp(),
get() {
const value = getTimeOriginTimestamp();
ObjectDefineProperty(Performance.prototype, 'timeOrigin', {
__proto__: null,
value,
});
return value;
},
set(value) {
ObjectDefineProperty(Performance.prototype, 'timeOrigin', {
__proto__: null,
value,
});
},
},
toJSON: {
__proto__: null,
Expand All @@ -224,15 +233,6 @@ ObjectDefineProperties(Performance.prototype, {
},
});

function refreshTimeOrigin() {
ObjectDefineProperty(Performance.prototype, 'timeOrigin', {
__proto__: null,
configurable: true,
enumerable: true,
value: getTimeOriginTimestamp(),
});
}

const performance = new InternalPerformance();

function dispatchBufferFull(type) {
Expand All @@ -246,5 +246,4 @@ setDispatchBufferFull(dispatchBufferFull);
module.exports = {
Performance,
performance,
refreshTimeOrigin,
};
1 change: 0 additions & 1 deletion lib/internal/process/pre_execution.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,6 @@ function setupTraceCategoryState() {
}

function setupPerfHooks() {
require('internal/perf/performance').refreshTimeOrigin();
require('internal/perf/utils').refreshTimeOrigin();
}

Expand Down