Skip to content

stream: dont access Object.prototype.type during TransformStream init #46389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
Feb 2, 2023
Merged

stream: dont access Object.prototype.type during TransformStream init #46389

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2a828b
stream: dont access Object.prototype.type during TransformStream init
debadree25 Jan 28, 2023
0b29636
fixup!
debadree25 Jan 30, 2023
034f49f
fixup!
debadree25 Jan 30, 2023
efb65e0
fixup
debadree25 Jan 30, 2023
a8aa8a2
fixup! use configurable
debadree25 Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/internal/webstreams/transformstream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,7 @@ function initializeTransformStream(
close() {
return transformStreamDefaultSinkCloseAlgorithm(stream);
},
__proto__: null
Comment thread
aduh95 marked this conversation as resolved.
Outdated
}, {
highWaterMark: writableHighWaterMark,
size: writableSizeAlgorithm,
Expand All @@ -382,6 +383,7 @@ function initializeTransformStream(
transformStreamErrorWritableAndUnblockWrite(stream, reason);
return PromiseResolve();
},
__proto__: null,
}, {
highWaterMark: readableHighWaterMark,
size: readableSizeAlgorithm,
Expand Down
15 changes: 15 additions & 0 deletions test/parallel/test-whatwg-transformstream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,3 +186,18 @@ class Source {
inspect(controller, { depth: 0 }),
/TransformStreamDefaultController \[/);
}

{
Object.defineProperty(Object.prototype, 'type', {
get: common.mustNotCall()
Comment thread
debadree25 marked this conversation as resolved.
Outdated
});

new TransformStream({
transform(chunk, controller) {
controller.enqueue(chunk);
},
flush(controller) {
controller.terminate();
}
});
Comment thread
aduh95 marked this conversation as resolved.
}