Skip to content

[18.x backport] http: res setheaders #46365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marco-ippolito wants to merge 2 commits into from
Closed

[18.x backport] http: res setheaders #46365

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcef834
http: res.setHeaders first implementation
marco-ippolito Jan 9, 2023
e835966
http: res.setHeader 18.x backport
marco-ippolito Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
http: res.setHeader 18.x backport
  • Loading branch information
@marco-ippolito
marco-ippolito committed Feb 21, 2023
commit e835966e1c4fcb6edae439a02001328ffaba1d17
3 changes: 3 additions & 0 deletions lib/_http_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,9 @@ function writeHead(statusCode, reason, obj) {
if (k) this.setHeader(k, obj[k]);
}
}
if (k === undefined && this._header) {
throw new ERR_HTTP_HEADERS_SENT('render');
}
// Only progressive api is used
headers = this[kOutHeaders];
} else {
Expand Down