Skip to content

stream: validate writable defaultEncoding #46322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Jan 30, 2023
Merged

stream: validate writable defaultEncoding #46322

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68193ee
stream: validate writable defaultEncoding
marco-ippolito Jan 23, 2023
f9a2d21
stream: test falsy defaultEncoding
marco-ippolito Jan 24, 2023
1b96251
stream: test object mode
marco-ippolito Jan 24, 2023
958633d
stream: refactor code style
marco-ippolito Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
stream: refactor code style
  • Loading branch information
@marco-ippolito
marco-ippolito committed Jan 25, 2023
commit 958633dd2ad99e170a38fec0df09264c9f94328c
9 changes: 5 additions & 4 deletions lib/internal/streams/writable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,13 +123,14 @@ function WritableState(options, stream, isDuplex) {
// encoding is 'binary' so we have to make this configurable.
// Everything else in the universe uses 'utf8', though.
const defaultEncoding = options?.defaultEncoding;

if (defaultEncoding && !Buffer.isEncoding(defaultEncoding)) {
if (defaultEncoding == null) {
this.defaultEncoding = 'utf8';
} else if (Buffer.isEncoding(defaultEncoding)) {
this.defaultEncoding = defaultEncoding;
} else {
throw new ERR_UNKNOWN_ENCODING(defaultEncoding);
}
Comment thread
marco-ippolito marked this conversation as resolved.

this.defaultEncoding = defaultEncoding || 'utf8';

// Not an actual buffer we keep track of, but a measurement
// of how much we're waiting to get pushed to some underlying
// socket or file.
Expand Down