Skip to content

[v18.x backport] stream: streams and webstreams interop related changes #46314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
debadree25 wants to merge 3 commits into from
Closed

[v18.x backport] stream: streams and webstreams interop related changes #46314

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c1a619
lib: add webstreams to Duplex.from()
debadree25 Jan 19, 2023
631afeb
doc: include webstreams in finished() and Duplex.from() parameters
debadree25 Jan 31, 2023
0291981
stream: remove brandchecks from stream duplexify
debadree25 Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
stream: remove brandchecks from stream duplexify 
Refs: #46190
Refs: #46205 (comment)
PR-URL: #46315
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
@debadree25
debadree25 committed May 23, 2023
commit 029198160bba7ef0325622e54d611df8d700ce30
12 changes: 2 additions & 10 deletions lib/internal/streams/duplexify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ const {
isReadableNodeStream,
isWritableNodeStream,
isDuplexNodeStream,
isReadableStream,
isWritableStream,
} = require('internal/streams/utils');
const eos = require('internal/streams/end-of-stream');
const {
Expand All @@ -33,16 +35,6 @@ const {
FunctionPrototypeCall,
} = primordials;


const {
isBrandCheck,
} = require('internal/webstreams/util');

const isReadableStream =
isBrandCheck('ReadableStream');
const isWritableStream =
isBrandCheck('WritableStream');

// This is needed for pre node 17.
class Duplexify extends Duplex {
constructor(options) {
Expand Down