Skip to content

Revert "src: let http2 streams end after session close" #46249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
santigimeno wants to merge 4 commits into from
Closed

Revert "src: let http2 streams end after session close" #46249

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3619cb3
Revert "src: let http2 streams end after session close"
santigimeno Jan 18, 2023
cceb018
Update test/known_issues/test-http2-trailers-after-session-close.js
Trott Feb 19, 2023
2f640df
Update test/known_issues/test-http2-trailers-after-session-close.js
Trott Feb 19, 2023
f3d066c
Update test/known_issues/test-http2-trailers-after-session-close.js
Trott Feb 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test/known_issues/test-http2-trailers-after-session-close.js
  • Loading branch information
@Trott
Trott authored Feb 19, 2023
commit 2f640df31b05ba191abded95b2af4ef8b9aeeec5
7 changes: 6 additions & 1 deletion test/known_issues/test-http2-trailers-after-session-close.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@

// Fixes: https://github.com/nodejs/node/issues/42713
const common = require('../common');
if (!common.hasCrypto)
if (!common.hasCrypto) {
// Remove require('assert').fail when issue is fixed and test
// is moved out of the known_issues directory.
require('assert').fail('missing crypto');
common.skip('missing crypto');
Comment thread
Trott marked this conversation as resolved.
}
// Change require('assert').fail to common.skip when issue is fixed and test
// is moved out of the known_issues directory
require('assert').fail('missing crypto');
Expand Down