Skip to content

crypto: avoid hang when no algorithm available #46237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Jan 19, 2023
Merged

crypto: avoid hang when no algorithm available #46237

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58dca48
crypto: avoid hang when no algorithm available
richardlau Jan 16, 2023
a954614
fixup! crypto: avoid hang when no algorithm available
richardlau Jan 17, 2023
86fa1f1
fixup! crypto: avoid hang when no algorithm available
richardlau Jan 18, 2023
cfdea22
fixup! crypto: avoid hang when no algorithm available
richardlau Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! crypto: avoid hang when no algorithm available
  • Loading branch information
@richardlau
richardlau committed Jan 17, 2023
commit a954614636fc0df45385bfb8d6a0dbf28c646499
4 changes: 2 additions & 2 deletions test/parallel/test-crypto-no-algorithm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ if (!common.hasOpenSSL3)
const assert = require('node:assert/strict');
const crypto = require('node:crypto');

{
if (common.isMainThread) {
// TODO(richardlau): Decide if `crypto.setFips` should error if the
// provider namd "fips" is not available.
Comment thread
richardlau marked this conversation as resolved.
Outdated
crypto.setFips(1);
crypto.randomBytes(20, common.mustCall((err, _) => {
crypto.randomBytes(20, common.mustCall((err) => {
// crypto.randomBytes should either succeed or fail but not hang.
if (err) {
assert.match(err.message, /digital envelope routines::unsupported/);
Expand Down