Skip to content

src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValid #46227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 14 commits into from
Jan 23, 2023
Merged

src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValid #46227

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ff9c478
src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValid
miguelteixeiraa Jan 16, 2023
f076935
src: fix node_url.cc code formatting
miguelteixeiraa Jan 16, 2023
b1f4c83
src: fix node_url.cc code formatting (back to what it was)
miguelteixeiraa Jan 16, 2023
95d3081
src: refactor EndsInANumber in node_url.cc to use string_view::rfind
miguelteixeiraa Jan 17, 2023
e9282ad
src: fix imports typo in node_url.cc
miguelteixeiraa Jan 17, 2023
a683d34
src: removes unnecessary if statement from EndsInANumber in node_url.cc
miguelteixeiraa Jan 17, 2023
d165e39
src: use string_view instead of string in EndsInANumber in node_url.cc
miguelteixeiraa Jan 17, 2023
573dd4a
src: fix string_view constructor call for IsIPv4NumberValid in node_u…
miguelteixeiraa Jan 17, 2023
b52bbd4
src: adds minor tweaks to EndsInANumber at node_url.cc
miguelteixeiraa Jan 18, 2023
3074383
src: adds comment to IsIPv4NumberValid conditions in node_url.cc
miguelteixeiraa Jan 18, 2023
de4f065
src: cast interators to size_t in IsIPv4NumberValid call in node_url.cc
miguelteixeiraa Jan 18, 2023
9058eb5
src: cast interator to const char* in IsIPv4NumberValid call in node_…
miguelteixeiraa Jan 18, 2023
b65769f
src: use &(*it) to make windows build pass + ::all_of instead of ::fi…
miguelteixeiraa Jan 19, 2023
9534455
src: refactor EndsInANumber to be more readable in node_url.cc
miguelteixeiraa Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: removes unnecessary if statement from EndsInANumber in node_url.cc
  • Loading branch information
@miguelteixeiraa
miguelteixeiraa committed Jan 17, 2023
commit a683d340f33c4094cb84b5087b46e1921d610218
5 changes: 0 additions & 5 deletions src/node_url.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,12 +421,7 @@ bool IsIPv4NumberValid(std::string_view input) {

return input.find_first_not_of("0123456789abcdefABCDEF", 2) ==
Comment thread
anonrig marked this conversation as resolved.
Outdated
std::string_view::npos;

} else {
Comment thread
anonrig marked this conversation as resolved.
Outdated
if (input.size() == 1) {
return true;
}

return input.find_first_not_of("01234567", 1) == std::string_view::npos;
}
}
Expand Down