Skip to content

events: change status of event.returnvalue to legacy #46175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Jan 19, 2023
Merged

events: change status of event.returnvalue to legacy #46175

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c173711
events: change status of `event.returnvalue` to legacy
deokjinkim Jan 11, 2023
4add9b3
use cancelable to determine returnValue
deokjinkim Jan 17, 2023
e8262f6
revise description of `event.returnValue`
deokjinkim Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
events: change status of event.returnvalue to legacy 
`event.returnvalue` is described as legacy in spec.
Plus, add missed '#'(private member) of defaultPrevented
in implementation.

Refs: https://dom.spec.whatwg.org/#interface-event
Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue
  • Loading branch information
@deokjinkim
deokjinkim committed Jan 11, 2023
commit c17371199ffb81876a9c8ced03537ba1be03ad13
4 changes: 4 additions & 0 deletions doc/api/events.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1846,8 +1846,11 @@ Sets the `defaultPrevented` property to `true` if `cancelable` is `true`.
added: v14.5.0
-->

> Stability: 3 - Legacy: Use [`event.defaultPrevented`][] instead.

* Type: {boolean} True if the event has not been canceled.

Returns a value which is opposite of the value returned by `defaultPrevented`.
Comment thread
deokjinkim marked this conversation as resolved.
Outdated
This is not used in Node.js and is provided purely for completeness.

#### `event.srcElement`
Expand Down Expand Up @@ -2168,6 +2171,7 @@ to the `EventTarget`.
[`emitter.listenerCount()`]: #emitterlistenercounteventname
[`emitter.removeListener()`]: #emitterremovelistenereventname-listener
[`emitter.setMaxListeners(n)`]: #emittersetmaxlistenersn
[`event.defaultPrevented`]: #eventdefaultprevented
[`event.stopPropagation()`]: #eventstoppropagation
[`event.target`]: #eventtarget
[`events.defaultMaxListeners`]: #eventsdefaultmaxlisteners
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/event_target.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ class Event {
get returnValue() {
if (!isEvent(this))
throw new ERR_INVALID_THIS('Event');
return !this.defaultPrevented;
return !this.#defaultPrevented;
Comment thread
deokjinkim marked this conversation as resolved.
Outdated
}

/**
Expand Down