Skip to content

test: remove 1 second delay from test #4616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 4 commits into from
Closed

test: remove 1 second delay from test #4616

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe885b8
test: remove 1 second delay from test
Trott Jan 11, 2016
3be4711
fixup: use readyState instead of event firing order
Trott Jan 11, 2016
30d1584
fixup: fix flakiness in test
Trott Jan 11, 2016
c5c09da
fixup: remove flakiness
Trott Jan 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: remove 1 second delay from test
  • Loading branch information
@Trott
Trott committed Jan 11, 2016
commit fe885b819d49807465579dfe10fd4fcdfa38ea00
8 changes: 4 additions & 4 deletions test/parallel/test-cluster-worker-wait-server-close.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ if (cluster.isWorker) {
worker.once('listening', function() {
net.createConnection(common.PORT, common.localhostIPv4, function() {
var socket = this;
this.on('end', function() {
connectionDone = true;
});
this.on('data', function() {
console.log('got data from client');
// socket definitely connected to worker if we got data
worker.disconnect();
setTimeout(function() {
socket.end();
connectionDone = true;
}, 1000);
socket.end();
});
});
});
Expand Down