Skip to content

deps: update V8 to 11.0 #46125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 8 commits into from
Closed

deps: update V8 to 11.0 #46125

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
09de414
deps: update V8 to 11.0.226.12
targos Jan 30, 2023
49b6e0f
build: reset embedder string to "-node.0"
targos Jan 30, 2023
fd8c0ad
src: update NODE_MODULE_VERSION to 115
targos Jan 7, 2023
4c47427
deps: always define V8_EXPORT_PRIVATE as no-op
targos Sep 21, 2022
e17583a
deps: silence irrelevant V8 warning
targos Jun 21, 2022
88f254b
deps: V8: cherry-pick 166fd2f38f44
targos Jan 7, 2023
ebea4f1
deps: V8: backport 1e4b71d99fea
targos Jan 30, 2023
74ba7bc
tools: update V8 gypfiles for 11.0
targos Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: always define V8_EXPORT_PRIVATE as no-op 
dllexport introduces issues when compiling with MSVC.
  • Loading branch information
@targos
targos committed Jan 30, 2023
commit 4c47427219a89736e97240df3fbf6b694671a41c
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.0',
'v8_embedder_string': '-node.1',

##### V8 defaults for Node.js #####

Expand Down
6 changes: 3 additions & 3 deletions deps/v8/src/base/macros.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,9 +389,9 @@ bool is_inbounds(float_t v) {

// Setup for Windows shared library export.
#ifdef BUILDING_V8_SHARED
#define V8_EXPORT_PRIVATE __declspec(dllexport)
#define V8_EXPORT_PRIVATE
#elif USING_V8_SHARED
#define V8_EXPORT_PRIVATE __declspec(dllimport)
#define V8_EXPORT_PRIVATE
#else
#define V8_EXPORT_PRIVATE
#endif // BUILDING_V8_SHARED
Expand All @@ -401,7 +401,7 @@ bool is_inbounds(float_t v) {
// Setup for Linux shared library export.
#if V8_HAS_ATTRIBUTE_VISIBILITY
#ifdef BUILDING_V8_SHARED
#define V8_EXPORT_PRIVATE __attribute__((visibility("default")))
#define V8_EXPORT_PRIVATE
#else
#define V8_EXPORT_PRIVATE
#endif
Expand Down