Skip to content

lib: make Error objects instantiation less vulnerable to prototype pollution #46065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aduh95 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

lib: make Error objects instantiation less vulnerable to prototype pollution #46065

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3742f74
lib: make `Error` instantiation less vulnerable to prototype pollution
aduh95 Jan 2, 2023
2e892fc
fixup! lib: make `Error` instantiation less vulnerable to prototype p…
aduh95 Jan 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! lib: make Error instantiation less vulnerable to prototype p… 
…ollution
  • Loading branch information
@aduh95
aduh95 committed Jan 2, 2023
commit 2e892fcfe9569b2be2a429cf1390ca6d432e2cd3
14 changes: 7 additions & 7 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,13 @@ class SystemError extends Error {
captureLargerStackTrace(this);

ObjectDefineProperties(this, {
code: {
__proto__: null,
value: key,
enumerable: true,
writable: true,
configurable: true,
},
[kIsNodeError]: {
__proto__: null,
value: true,
Expand All @@ -276,13 +283,6 @@ class SystemError extends Error {
writable: true,
configurable: true,
},
code: {
__proto__: null,
value: key,
enumerable: true,
writable: true,
configurable: true,
},
info: {
__proto__: null,
value: context,
Expand Down