Skip to content

test: print failed JS/parallel tests #45960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
Dec 27, 2022
Merged

test: print failed JS/parallel tests #45960

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c6c1fb
test: print failed JS/parallel tests
GeoffreyBooth Dec 24, 2022
639e1a8
add type hint
GeoffreyBooth Dec 24, 2022
a645ef6
Add newline between failed test outputs
GeoffreyBooth Dec 24, 2022
fa70072
Match style for variable names
GeoffreyBooth Dec 25, 2022
193fdc0
Add import for backward compatibility
GeoffreyBooth Dec 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add newline between failed test outputs
  • Loading branch information
@GeoffreyBooth
GeoffreyBooth committed Dec 25, 2022
commit a645ef6f44904d413fe7510d8a36647fd213f136
5 changes: 3 additions & 2 deletions tools/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,7 @@ def HasRun(self, output):
print("--- %s ---" % PrintCrashed(output.output.exit_code))
if output.HasTimedOut():
print("--- TIMEOUT ---")
print("\n") # Two blank lines between failures, for visual separation

def Truncate(self, str, length):
if length and (len(str) > (length - 3)):
Expand Down Expand Up @@ -1779,9 +1780,9 @@ def should_keep(case):
sys.stderr.write("%4i (%s) %s\n" % (i, t, entry.GetLabel()))

if result['allPassed']:
Comment thread
GeoffreyBooth marked this conversation as resolved.
print('All tests passed.')
print("\nAll tests passed.")
else:
print('Failed tests:')
print("\nFailed tests:")
for failedTest in result['failed']:
print(EscapeCommand(failedTest.command))

Expand Down