Skip to content

doc: remove port from example in url.hostname #45927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Dec 24, 2022
Merged

doc: remove port from example in url.hostname #45927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: remove port from example in url.hostname 
If port is used for `url.hostname`, `url.hostname`
is not working. So remove port from example in
`url.hostname`.
  • Loading branch information
@deokjinkim
deokjinkim committed Dec 24, 2022
commit 6ece8fd5790831880cfd290dfc6b0f93fc27c723
2 changes: 1 addition & 1 deletion doc/api/url.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ console.log(myURL.hostname);
// Prints example.org

// Setting the hostname does not change the port
Comment thread
deokjinkim marked this conversation as resolved.
myURL.hostname = 'example.com:82';
myURL.hostname = 'example.com';
console.log(myURL.href);
// Prints https://example.com:81/foo

Expand Down