Skip to content

fs: handle fixes #45909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 5 commits into from
Closed

fs: handle fixes #45909

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
25eff75
fs: allow gc of stream even if handle is alive
ronag Dec 19, 2022
5cca6cb
fs: don't block stream destroy if there are other handle refs
ronag Dec 19, 2022
036944c
fixup
ronag Dec 25, 2022
c6c0899
fixup
ronag Dec 25, 2022
f2f0333
fixup
ronag Dec 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fs: don't block stream destroy if there are other handle refs
  • Loading branch information
@ronag
ronag committed Dec 19, 2022
commit 5cca6cbf34fa2a129535d4e9cfbebfe993353c25
9 changes: 7 additions & 2 deletions lib/internal/fs/streams.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,13 @@ const FileHandleOperations = (handle, closeHandler) => {
handle.off('close', closeHandler);
Copy link
Copy Markdown
Member Author

@ronag ronag Dec 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid keeping stream alive until file handle is closed.


handle[kUnref]();
PromisePrototypeThen(handle.close(),
() => cb(), cb);
if (handle[kFd] !== -1) {
// Someone else has a ref to the handle.
process.nextTick(cb);
Copy link
Copy Markdown
Member Author

@ronag ronag Dec 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stream can finish teardown even if file handle isn't closed, if it has refs

} else {
PromisePrototypeThen(handle.close(),
() => cb(), cb);
}
},
read: (fd, buf, offset, length, pos, cb) => {
PromisePrototypeThen(handle.read(buf, offset, length, pos),
Expand Down