Skip to content

crypto: fix WebCryptoAPI WebIDL harness #45590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panva wants to merge 13 commits into from
Closed

crypto: fix WebCryptoAPI WebIDL harness #45590

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ef1eeea
crypto: fix WebCryptoAPI WebIDL harness
panva Nov 22, 2022
d67a4d3
enumerable CryptoKey attributes
panva Nov 22, 2022
969d71b
extractable and algorithm this
panva Nov 22, 2022
57fe0e3
check getRandomValues argument presence
panva Nov 22, 2022
321fab6
global crypto getter this
panva Nov 22, 2022
624ecb0
prototype CryptoKey is not Function.prototype
panva Nov 22, 2022
06e76ae
expectations cleanup
panva Nov 22, 2022
fc124b3
cleanup
panva Nov 22, 2022
dee61b3
apply review feedback
panva Nov 22, 2022
0c0eff8
update test-crypto-worker-thread.js
panva Nov 22, 2022
056fd31
type and usages this
panva Nov 22, 2022
0490a01
review feedback
panva Nov 23, 2022
01945b8
review feedback
panva Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
global crypto getter this
  • Loading branch information
@panva
panva committed Nov 22, 2022
commit 321fab6fc0bb60a86d160f6860f39e86ea1b69cf
4 changes: 4 additions & 0 deletions lib/internal/process/pre_execution.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const {
} = require('internal/util');

const {
ERR_INVALID_THIS,
ERR_MANIFEST_ASSERT_INTEGRITY,
ERR_NO_CRYPTO,
} = require('internal/errors').codes;
Expand Down Expand Up @@ -278,6 +279,9 @@ function setupWebCrypto() {
ObjectDefineProperty(globalThis, 'crypto',
{ __proto__: null, ...ObjectGetOwnPropertyDescriptor({
get crypto() {
if (this !== globalThis && this !== undefined)
Comment thread
panva marked this conversation as resolved.
Outdated
throw new ERR_INVALID_THIS(
'globalThis or undefined');
Comment thread
panva marked this conversation as resolved.
Outdated
return webcrypto.crypto;
}
}, 'crypto') });
Expand Down
3 changes: 1 addition & 2 deletions test/wpt/status/WebCryptoAPI.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
"fail": {
"expected": [
"CryptoKey interface: existence and properties of interface object",
"CryptoKey interface: existence and properties of interface prototype object",
"Window interface: attribute crypto"
"CryptoKey interface: existence and properties of interface prototype object"
]
}
}
Expand Down