Skip to content

http: throw ERR_HTTP_HEADERS_SENT when sending multiple writeHead #45508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Nov 24, 2022
Merged

http: throw ERR_HTTP_HEADERS_SENT when sending multiple writeHead #45508

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8c92903
test: test case for multiple res.writeHead and res.getHeader
marco-ippolito Nov 17, 2022
24d17b6
fix: throw ERR_HTTP_HEADERS_SENT error after multiple writeHead
marco-ippolito Nov 18, 2022
9ac34d7
fix: changed error label
marco-ippolito Nov 18, 2022
ba88877
fix: removed error message check and added common.mustCall
marco-ippolito Nov 19, 2022
0721653
fix: replaced writeHead with socket.write
marco-ippolito Nov 22, 2022
0ccb0c2
fix: removed res.end
marco-ippolito Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: throw ERR_HTTP_HEADERS_SENT error after multiple writeHead
  • Loading branch information
@marco-ippolito
marco-ippolito committed Nov 23, 2022
commit 24d17b616e59ad2a6d9f0ce78af7c8c148d99cd8
5 changes: 5 additions & 0 deletions lib/_http_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,11 @@ ServerResponse.prototype._implicitHeader = function _implicitHeader() {

ServerResponse.prototype.writeHead = writeHead;
function writeHead(statusCode, reason, obj) {

if (this._header) {
throw new ERR_HTTP_HEADERS_SENT('writeHead');
Comment thread
marco-ippolito marked this conversation as resolved.
Outdated
}

const originalStatusCode = statusCode;

statusCode |= 0;
Expand Down
60 changes: 0 additions & 60 deletions test/parallel/test-http-write-head-2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,63 +59,3 @@ const http = require('http');
}));
}));
}

{
const server = http.createServer((req, res) => {
try {
res.writeHead(200,[ 'test', '1' ]);
res.writeHead(200,[ 'test2', '2' ]);
res.end();
} catch (error) {
assert.strictEqual(err.code, 'ERR_INVALID_ARG_VALUE');
}
});

server.listen(0, () => {
http.get({ port: server.address().port }, common.mustCall((res) => {
assert.equal('test' in res.headers, false)
assert.strictEqual(res.headers.test2, '2');
res.resume().on('end', common.mustCall(() => {
server.close();
}));
}));
});
}

{
const server = http.createServer((req, res) => {
res.writeHead(200,[ 'test', '1' ]);
assert.equal(res.getHeader('test'), undefined)
res.end();
});

server.listen(0, () => {
http.get({ port: server.address().port }, (res) => {
assert.strictEqual(res.headers.test, '1');
res.resume().on('end', common.mustCall(() => {
server.close();
}));
});
});
}

{
const server = http.createServer((req, res) => {
res.setHeader('test2','2')
res.writeHead(200,[ 'test', '1' ]);
assert.strictEqual(res.getHeader('test'), '1');
assert.strictEqual(res.getHeader('test2'), '2');
res.end();
});

server.listen(0, () => {
http.get({ port: server.address().port }, (res) => {
assert.strictEqual(res.headers.test, '1');
assert.strictEqual(res.headers.test2, '2');
res.resume().on('end', common.mustCall(() => {
server.close();
}));
});
});
}

24 changes: 23 additions & 1 deletion test/parallel/test-http-write-head.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const s = http.createServer(common.mustCall((req, res) => {
}, {
code: 'ERR_HTTP_HEADERS_SENT',
name: 'Error',
message: 'Cannot render headers after they are sent to the client'
message: 'Cannot writeHead headers after they are sent to the client'
});

res.end();
Expand All @@ -76,3 +76,25 @@ function runTest() {
response.resume();
}));
}

{
const server = http.createServer((req, res) => {
Comment thread
anonrig marked this conversation as resolved.
Outdated
res.writeHead(200, [ 'test', '1' ]);
assert.throws(() => res.writeHead(200, [ 'test2', '2' ]), {
code: 'ERR_HTTP_HEADERS_SENT',
name: 'Error',
message: 'Cannot writeHead headers after they are sent to the client'
});
res.end();
});

server.listen(0, () => {
http.get({ port: server.address().port }, (res) => {
assert.strictEqual(res.headers.test, '1');
assert.strictEqual('test2' in res.headers, false);
Copy link
Copy Markdown
Member

@lpinca lpinca Nov 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, feel free to ignore.

Suggested change
assert.strictEqual('test2' in res.headers, false);
assert.strictEqual(res.headers.test2, undefined);

res.resume().on('end', common.mustCall(() => {
server.close();
}));
});
});
}