Skip to content

async_hooks: AsyncLocalStorage to diagnostics_channel integration #45277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Qard wants to merge 4 commits into from
Closed

async_hooks: AsyncLocalStorage to diagnostics_channel integration #45277

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0438150
lib: add tracing channel to diagnostics_channel
Oct 9, 2022
f8605a6
diagnostics_channel: make tracing channels safer and support symbol n…
Nov 9, 2022
789d1e0
diagnostics_channel: Avoid wrapping with no subscribers
Nov 9, 2022
e72265b
async_hooks: AsyncLocalStorage to diagnostics_channel integration
Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
diagnostics_channel: Avoid wrapping with no subscribers
  • Loading branch information
Stephen Belanger committed Nov 9, 2022
commit 789d1e072eed046a209c4ac3956b3f45847bd05a
3 changes: 3 additions & 0 deletions lib/diagnostics_channel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ class TracingChannel {
}

traceSync(fn, ctx = {}, thisArg, ...args) {
if (!this.hasSubscribers) return ReflectApply(fn, thisArg, args);
const { start, end, error } = this.#channels;
start.publish(ctx);
try {
Expand All @@ -198,6 +199,7 @@ class TracingChannel {
}

tracePromise(fn, ctx = {}, thisArg, ...args) {
Comment thread
mcollina marked this conversation as resolved.
if (!this.hasSubscribers) return ReflectApply(fn, thisArg, args);
const { asyncEnd, start, end, error } = this.#channels;
start.publish(ctx);

Expand Down Expand Up @@ -227,6 +229,7 @@ class TracingChannel {
}

traceCallback(fn, position = 0, ctx = {}, thisArg, ...args) {
if (!this.hasSubscribers) return ReflectApply(fn, thisArg, args);
const { start, end, asyncEnd, error } = this.#channels;
start.publish(ctx);

Expand Down