Skip to content

[v14.x backport] loader: make require.resolve throw for unknown builtin modules #45263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danielleadams wants to merge 1 commit into from
Closed

[v14.x backport] loader: make require.resolve throw for unknown builtin modules #45263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
loader: make require.resolve throw for unknown builtin modules 
Fixes: #43274

PR-URL: #43336
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@zhmushan @danielleadams
zhmushan authored and danielleadams committed Nov 1, 2022
commit 0924b9928ecbefd2ecd62d250cf37eda049037e3
16 changes: 10 additions & 6 deletions lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,19 +743,19 @@ Module._load = function(request, parent, isMain) {
}
}

const filename = Module._resolveFilename(request, parent, isMain);
if (StringPrototypeStartsWith(filename, 'node:')) {
if (StringPrototypeStartsWith(request, 'node:')) {
// Slice 'node:' prefix
const id = StringPrototypeSlice(filename, 5);
const id = StringPrototypeSlice(request, 5);

const module = loadNativeModule(id, request);
if (!module?.canBeRequiredByUsers) {
throw new ERR_UNKNOWN_BUILTIN_MODULE(filename);
throw new ERR_UNKNOWN_BUILTIN_MODULE(request);
}

return module.exports;
}

const filename = Module._resolveFilename(request, parent, isMain);
const cachedModule = Module._cache[filename];
if (cachedModule !== undefined) {
updateChildren(parent, cachedModule, true);
Expand Down Expand Up @@ -814,8 +814,12 @@ Module._load = function(request, parent, isMain) {
};

Module._resolveFilename = function(request, parent, isMain, options) {
if (StringPrototypeStartsWith(request, 'node:') ||
NativeModule.canBeRequiredByUsers(request)) {
if (
(
StringPrototypeStartsWith(request, 'node:') &&
NativeModule.canBeRequiredByUsers(StringPrototypeSlice(request, 5))
) || NativeModule.canBeRequiredByUsers(request)
) {
return request;
}

Expand Down
10 changes: 10 additions & 0 deletions test/parallel/test-require-resolve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,13 @@ require(fixtures.path('resolve-paths', 'default', 'verify-paths.js'));
assert.strictEqual(resolvedPaths.includes('/node_modules'), false);
});
}

{
assert.strictEqual(require.resolve('https'), 'https');
assert.strictEqual(require.resolve('fs'), 'fs');

assert.throws(
() => require.resolve('unknown'),
Comment on lines +85 to +89
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be passing when using the prefix, otherwise the original issue has not been fixed.

Suggested change
assert.strictEqual(require.resolve('https'), 'https');
assert.strictEqual(require.resolve('fs'), 'fs');
assert.throws(
() => require.resolve('unknown'),
assert.strictEqual(require.resolve('node:https'), 'node:https');
assert.strictEqual(require.resolve('node:fs'), 'node:fs');
assert.throws(
() => require.resolve('node:unknown'),

{ code: 'MODULE_NOT_FOUND' },
);
}