Skip to content

install: remove unused language files #45138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis wants to merge 1 commit into from
Closed

install: remove unused language files #45138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: remove unused language files 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
  • Loading branch information
@bnoordhuis
bnoordhuis committed Oct 24, 2022
commit 0fa45f9880ba0055946fcf8cd8c16c76c936239d
35 changes: 0 additions & 35 deletions tools/msvs/msi/i18n/de-de.wxl
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions tools/msvs/msi/i18n/it-it.wxl
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions tools/msvs/msi/i18n/zh-cn.wxl
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions tools/msvs/msi/nodemsi.wixproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,6 @@
</WixExtension>
</ItemGroup>
<ItemGroup>
<!--
<EmbeddedResource Include="i18n\de-de.wxl" />
<EmbeddedResource Include="i18n\it-it.wxl" />
<EmbeddedResource Include="i18n\zh-cn.wxl" />
-->
<EmbeddedResource Include="i18n\en-us.wxl" />
</ItemGroup>
<ItemGroup>
Expand All @@ -94,16 +89,5 @@
<PropertyGroup>
<PostBuildEvent>move "!(TargetPath)" "$(TargetDir)\$(TargetFileName)"
move "!(TargetPdbPath)" "$(TargetDir)\$(TargetPdbName)"</PostBuildEvent>
<!--
<PostBuildEvent>
"$(WixToolPath)\torch.exe" -t language "$(TargetDir)en-US\$(TargetFileName)" "$(TargetDir)de-de\$(TargetFileName)" -out "$(TargetDir)transforms\de-de.mst"
"$(WixToolPath)\torch.exe" -t language "$(TargetDir)en-US\$(TargetFileName)" "$(TargetDir)it-it\$(TargetFileName)" -out "$(TargetDir)transforms\it-it.mst"
"$(WixToolPath)\torch.exe" -t language "$(TargetDir)en-US\$(TargetFileName)" "$(TargetDir)zh-cn\$(TargetFileName)" -out "$(TargetDir)transforms\zh-cn.mst"
cscript.exe "$(WindowsSDK80Path)bin\$(Platform)\WiSubStg.vbs" "$(TargetDir)en-US\$(TargetFileName)" "$(TargetDir)transforms\de-de.mst" 1031
cscript.exe "$(WindowsSDK80Path)bin\$(Platform)\WiSubStg.vbs" "$(TargetDir)en-US\$(TargetFileName)" "$(TargetDir)transforms\it-it.mst" 1040
cscript.exe "$(WindowsSDK80Path)bin\$(Platform)\WiSubStg.vbs" "$(TargetDir)en-US\$(TargetFileName)" "$(TargetDir)transforms\zh-cn.mst" 2052
cscript.exe "$(WindowsSDK80Path)bin\$(Platform)\WiLangId.vbs" "$(TargetDir)en-US\$(TargetFileName)" Package 1031,1033,1040,2052
</PostBuildEvent>
-->
</PropertyGroup>
</Project>