Skip to content

fs: fix opts.filter issue in cp async #44922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Oct 10, 2022
Merged

fs: fix opts.filter issue in cp async #44922

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bc9f40
fs: fix opts.filter issue in cp async
thoqbk Oct 8, 2022
b65df06
fs: use if instead of ternary
thoqbk Oct 9, 2022
3fe69b8
Update lib/internal/fs/cp/cp.js
thoqbk Oct 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update lib/internal/fs/cp/cp.js 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@thoqbk @aduh95
thoqbk and aduh95 authored Oct 9, 2022
commit 3fe69b82b4f2b861ae48ccd54cce8abe1b269d0e
2 changes: 1 addition & 1 deletion lib/internal/fs/cp/cp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ async function cpFn(src, dest, opts) {

async function checkPaths(src, dest, opts) {
if (opts.filter && !(await opts.filter(src, dest))) {
return { skipped: true };
return { __proto__: null, skipped: true };
}
const { 0: srcStat, 1: destStat } = await getStats(src, dest, opts);
if (destStat) {
Expand Down