Skip to content

process: fix uid/gid validation to avoid crash #44910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Oct 10, 2022
Merged

process: fix uid/gid validation to avoid crash #44910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
process: fix uid/gid validation to avoid crash 
id |= 0 turns unsigned 32-bit integer values exceeding the unsigned
31-bit range into negative integers, causing a crash. Use id >>>= 0
instead, which works properly for all unsigned 32-bit integers.

Refs: #36786
  • Loading branch information
@tniessen
tniessen committed Oct 7, 2022
commit 37479e92b5e80df9422e2568cfe5116364120ea5
2 changes: 1 addition & 1 deletion lib/internal/bootstrap/switches/does_own_process_state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ function wrapPosixCredentialSetters(credentials) {
function wrapIdSetter(type, method) {
return function(id) {
validateId(id, 'id');
if (typeof id === 'number') id |= 0;
if (typeof id === 'number') id >>>= 0;
// Result is 0 on success, 1 if credential is unknown.
const result = method(id);
if (result === 1) {
Expand Down
18 changes: 7 additions & 11 deletions test/parallel/test-process-uid-gid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,13 @@ assert.throws(() => {

// Passing -0 shouldn't crash the process
// Refs: https://github.com/nodejs/node/issues/32750
try { process.setuid(-0); } catch {
// Continue regardless of error.
}
try { process.seteuid(-0); } catch {
// Continue regardless of error.
}
try { process.setgid(-0); } catch {
// Continue regardless of error.
}
try { process.setegid(-0); } catch {
// Continue regardless of error.
// And neither should values exceeding 2 ** 31 - 1.
for (const id of [-0, 2 ** 31, 2 ** 32 - 1]) {
for (const fn of [process.setuid, process.setuid, process.setgid, process.setegid]) {
try { fn(id); } catch {
// Continue regardless of error.
}
}
}

// If we're not running as super user...
Expand Down