Skip to content

events: make sure console functions exist #4479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidvgalbraith wants to merge 6 commits into from
Closed

events: make sure console functions exist #4479

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
362d832
events: make sure console functions exist
Dec 30, 2015
9f8eddb
initialize console in defaultMaxListeners setter
Jan 1, 2016
04a9276
test: overwrite stderr.write instead of checking e._events
Jan 4, 2016
ff4065e
global console exists spec cleanups
Jan 11, 2016
e1a14e7
Use the default export EventEmitter from events
Jan 12, 2016
7152739
TODO validate console
Jan 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
TODO validate console
  • Loading branch information
Dave committed Jan 12, 2016
commit 7152739f4cefeded4d17d792eb5660448218b69a
1 change: 1 addition & 0 deletions test/parallel/test-global-console-exists.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ const e = new EventEmitter();
e.on('hello', function() {});
e.on('hello', function() {});

// TODO validate console
Copy link
Copy Markdown
Member

@jasnell jasnell Jan 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add the comment vs. adding the validation?

Copy link
Copy Markdown
Author

@davidvgalbraith davidvgalbraith Jan 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per earlier discussion (#4479 (diff)) I don't think it's actually possible to validate the console here in any significant way, but @thefourtheye requested a comment about validating it.

Copy link
Copy Markdown
Member

@jasnell jasnell Jan 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh :-) lol completely missed that one

assert.equal(write_calls, 2);
Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Jan 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also assert if the console object is properly initialized by now?

Copy link
Copy Markdown
Author

@davidvgalbraith davidvgalbraith Jan 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's any way we can do that without incidentally initializing it. Our prior logging would have failed if console didn't initialize properly.

Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Jan 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about checking if console.error function exists by the time control reaches here?

Copy link
Copy Markdown
Author

@davidvgalbraith davidvgalbraith Jan 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a reference to console.error will compile console if it isn't already compiled.

Copy link
Copy Markdown
Author

@davidvgalbraith davidvgalbraith Jan 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we could inspect require('native_module')._cache.console.

Copy link
Copy Markdown
Author

@davidvgalbraith davidvgalbraith Jan 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scratch that -- Error: Cannot find module 'native_module'

Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Jan 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, my office time has started. I'll think about this when I find time today. Let's not block this PR because of this. Perhaps you might want to leave a TODO or something in the test for the timebeing.


EventEmitter.defaultMaxListeners = old_default;