Skip to content

esm, loader: tidy ESMLoader internals #44701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
Sep 19, 2022
Merged

esm, loader: tidy ESMLoader internals #44701

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
26795de
esm,loader: tidy ESMLoader internals
JakobJingleheimer Sep 17, 2022
e52919f
fixup! esm,loaders: tidy ESMLoader internals
JakobJingleheimer Sep 17, 2022
b047e56
CR feedback
JakobJingleheimer Sep 18, 2022
d6b4348
revert empty object initialisation back to `ObjectCreate(null)`
JakobJingleheimer Sep 18, 2022
c94e59c
Update lib/internal/modules/esm/loader.js
JakobJingleheimer Sep 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update lib/internal/modules/esm/loader.js 
Co-authored-by: Geoffrey Booth <456802+GeoffreyBooth@users.noreply.github.com>
  • Loading branch information
@JakobJingleheimer @GeoffreyBooth
JakobJingleheimer and GeoffreyBooth authored Sep 18, 2022
commit c94e59cf261c0d72d5a194f640aeb46015ace99c
2 changes: 1 addition & 1 deletion lib/internal/modules/esm/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ class ESMLoader {
globalPreload: [],

/**
* Phase 2 of 2 in ESM loading (phase 2 is below).
* Phase 2 of 2 in ESM loading (phase 1 is below).
* @private
* @property {KeyedHook[]} load Last-in-first-out collection of loader hooks.
*/
Expand Down