Skip to content

test: fix test-runner-inspect #44620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Sep 14, 2022
Merged

test: fix test-runner-inspect #44620

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
607b47a
test: fix test-runner-inspect
MoLow Sep 12, 2022
c7f99b1
CR
MoLow Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
CR
  • Loading branch information
@MoLow
MoLow committed Sep 12, 2022
commit c7f99b10c52ec428f0da1df462f7cac25dd673bf
5 changes: 3 additions & 2 deletions lib/internal/test_runner/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ const {

const { spawn } = require('child_process');
const { readdirSync, statSync } = require('fs');
const readline = require('readline/promises');
// TODO(aduh95): switch to internal/readline/interface when backporting to Node.js 16.x is no longer a concern.
const { createInterface } = require('readline');
const console = require('internal/console/global');
const {
codes: {
Expand Down Expand Up @@ -131,7 +132,7 @@ function runTestFile(path, root, inspectPort) {
});

if (isUsingInspector()) {
const rl = readline.createInterface({ input: child.stderr });
const rl = createInterface({ input: child.stderr });
rl.on('line', (line) => {
if (isInspectorMessage(line)) {
process.stderr.write(line + '\n');
Expand Down