Skip to content

tools: make utils.SearchFiles deterministic #44496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Oct 4, 2022
Merged

tools: make utils.SearchFiles deterministic #44496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tools: make utils.SearchFiles deterministic 
`glob.glob` on Linux returns files in the order returned by the
filesystem driver, and the output from this function is stuffed by
the Electron build process straight into the `config.gypi` header,
causing non-reproducible builds.

See this log for an example of the nondeterminism:
https://rb.zq1.de/compare.factory-20220901/diffs/nodejs-electron-compare.out
  • Loading branch information
@brjsp
brjsp committed Sep 5, 2022
commit 30253ac23bee74b652e8d8dc2e7d09de0b8e01ee
2 changes: 1 addition & 1 deletion tools/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,4 +112,4 @@ def SearchFiles(dir, ext):
list = glob.glob(dir+ '/**/*.' + ext, recursive=True)
if sys.platform == 'win32':
list = [ x.replace('\\', '/')for x in list]
return list
return sorted(list)