Skip to content

[v18.x backport] backport recent fixes to flaky tests #44473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 7 commits into from
Closed

[v18.x backport] backport recent fixes to flaky tests #44473

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9cdbf6b
bootstrap: check more metadata when loading the snapshot
joyeecheung Aug 9, 2022
62036e0
debugger: decrease timeout used to wait for the port to be free
joyeecheung Aug 24, 2022
a897b50
test: raise sleep times in child process tests
joyeecheung Aug 25, 2022
e521284
test: split heap prof tests
joyeecheung Aug 25, 2022
5dd57ef
test: make the vm timeout escape tests more lenient
joyeecheung Aug 29, 2022
36b60c6
test: deflake child process exec timeout tests
joyeecheung Aug 25, 2022
5aad691
test: avoid race in file write stream handle tests
joyeecheung Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: raise sleep times in child process tests 
sequential/test-child-process-execsync and
parallel/test-child-process-spawnsync-timeout are both flaky
on azure Windows machines, where it may take longer for Node.js
to launch and receive output from child processes. These tests
work by spawning a child processes that is supposed to sleep
for a long time, but the option is configured so that Node.js
would terminate them early when a shorter timeout is reached.
Then the tests assert that the time taken for the whole thing
is shorter than the specified sleep time (meaning the process
don't actually get to sleep for that long). To make the tests
less brittle on azure Windows, this patch raises the sleep
times in those tests on Windows platform, so that the overhead
can be taken into account there.

PR-URL: #44375
Refs: nodejs/build#3014
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
  • Loading branch information
@joyeecheung
joyeecheung committed Sep 6, 2022
commit a897b500710b72efeda87ae0fd44f62f4c1ade15
9 changes: 8 additions & 1 deletion test/parallel/test-child-process-spawnsync-timeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,14 @@ const { debuglog, getSystemErrorName } = require('util');
const debug = debuglog('test');

const TIMER = 200;
const SLEEP = common.platformTimeout(5000);
let SLEEP = common.platformTimeout(5000);

if (common.isWindows) {
// Some of the windows machines in the CI need more time to launch
// and receive output from child processes.
// https://github.com/nodejs/build/issues/3014
SLEEP = common.platformTimeout(15000);
}

switch (process.argv[2]) {
case 'child':
Expand Down
8 changes: 7 additions & 1 deletion test/sequential/test-child-process-execsync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,13 @@ const { execFileSync, execSync, spawnSync } = require('child_process');
const { getSystemErrorName } = require('util');

const TIMER = 200;
const SLEEP = 2000;
let SLEEP = 2000;
if (common.isWindows) {
// Some of the windows machines in the CI need more time to launch
// and receive output from child processes.
// https://github.com/nodejs/build/issues/3014
SLEEP = 10000;
}

const execOpts = { encoding: 'utf8', shell: true };

Expand Down