Skip to content

test: split report OOM tests #44389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 2 commits into from
Closed

test: split report OOM tests #44389

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48ee925
test: split report OOM tests
joyeecheung Aug 25, 2022
8bf17a0
fixup! test: split report OOM tests
joyeecheung Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! test: split report OOM tests
  • Loading branch information
@joyeecheung
joyeecheung committed Aug 25, 2022
commit 8bf17a0a31f5f9bfefa959bf84dad018423aa5cb
2 changes: 1 addition & 1 deletion test/report/test-report-fatalerror-oomerror-compact.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const fixtures = require('../common/fixtures');
// Common args that will cause an out-of-memory error for child process.
const ARGS = [
'--max-old-space-size=20',
fixtures.path('report-oom')
fixtures.path('report-oom'),
];

{
Expand Down
2 changes: 1 addition & 1 deletion test/report/test-report-fatalerror-oomerror-directory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const fixtures = require('../common/fixtures');
// Common args that will cause an out-of-memory error for child process.
const ARGS = [
'--max-old-space-size=20',
fixtures.path('report-oom')
fixtures.path('report-oom'),
];

{
Expand Down
3 changes: 1 addition & 2 deletions test/report/test-report-fatalerror-oomerror-filename.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

require('../common');
const assert = require('assert');
const fs = require('fs');
const helper = require('../common/report.js');
const spawnSync = require('child_process').spawnSync;
const tmpdir = require('../common/tmpdir');
Expand All @@ -13,7 +12,7 @@ const fixtures = require('../common/fixtures');
// Common args that will cause an out-of-memory error for child process.
const ARGS = [
'--max-old-space-size=20',
fixtures.path('report-oom')
fixtures.path('report-oom'),
];

{
Expand Down
4 changes: 2 additions & 2 deletions test/report/test-report-fatalerror-oomerror-not-set.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

require('../common');
const assert = require('assert');
const fs = require('fs');
const helper = require('../common/report.js');
const spawnSync = require('child_process').spawnSync;
const tmpdir = require('../common/tmpdir');
Expand All @@ -13,10 +12,11 @@ const fixtures = require('../common/fixtures');
// Common args that will cause an out-of-memory error for child process.
const ARGS = [
'--max-old-space-size=20',
fixtures.path('report-oom')
fixtures.path('report-oom'),
];

{
tmpdir.refresh();
// Verify that --report-on-fatalerror is respected when not set.
const args = ARGS;
const child = spawnSync(process.execPath, args, { cwd: tmpdir.path });
Expand Down
3 changes: 1 addition & 2 deletions test/report/test-report-fatalerror-oomerror-set.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

require('../common');
const assert = require('assert');
const fs = require('fs');
const helper = require('../common/report.js');
const spawnSync = require('child_process').spawnSync;
const tmpdir = require('../common/tmpdir');
Expand All @@ -13,7 +12,7 @@ const fixtures = require('../common/fixtures');
// Common args that will cause an out-of-memory error for child process.
const ARGS = [
'--max-old-space-size=20',
fixtures.path('report-oom')
fixtures.path('report-oom'),
];

{
Expand Down