Skip to content

src: add support for externally shared js builtins #44376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 6 commits into from
Closed

src: add support for externally shared js builtins #44376

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b7d4bcd
src: add support for externally shared js builtins
mhdawson Aug 24, 2022
5428aa2
squash: address linters
mhdawson Aug 26, 2022
5dd4c99
Update doc/contributing/maintaining-dependencies.md
mhdawson Sep 2, 2022
6f6d80e
squash: address comments
mhdawson Sep 2, 2022
a614c7b
squash: fixup
mhdawson Sep 9, 2022
eb708c8
Update doc/contributing/maintaining-dependencies.md
mhdawson Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: address linters 
Signed-off-by: Michael Dawson <mdawson@devrus.com>
  • Loading branch information
@mhdawson
mhdawson committed Aug 26, 2022
commit 5428aa24da9623997cc06b88aca2630a74e5b75a
2 changes: 1 addition & 1 deletion configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1974,7 +1974,7 @@ def make_bin_override():
for builtin in sharable_builtins:
builtin_id = 'node_shared_builtin_' + builtin.replace('/', '_') + '_path'
if getattr(options, builtin_id):
if options.with_intl is 'none':
if options.with_intl == 'none':
option_name = '--shared-builtin-' + builtin + '-path'
error(option_name + ' is incompatible with --with-intl=none' )
else:
Expand Down
6 changes: 2 additions & 4 deletions src/node_builtins.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,10 +243,8 @@ void BuiltinLoader::AddExternalizedBuiltin(const char* id,
std::string source;
int r = ReadFileSync(&source, filename);
if (r != 0) {
fprintf(stderr,
"Cannot load externalized builtin: \"%s:%s\".\n",
id,
filename);
fprintf(
stderr, "Cannot load externalized builtin: \"%s:%s\".\n", id, filename);
ABORT();
return;
}
Expand Down