Skip to content

[v16.x] build: add windows-2022 to v16.x actions #44365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dennisameling wants to merge 1 commit into from
Closed

[v16.x] build: add windows-2022 to v16.x actions #44365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: add windows-2022 to v16.x actions 
This was reverted in the commit mentioned below due to a
compiler bug. The bug got resolved in MSVC 14.33, which
is part of the GitHub Actions 20220821.1 image for
windows-2022.

Ref: 79e2ab2
Ref: #42560
Ref: https://developercommunity.visualstudio.com/t/Failed-to-compile-nodejs-16140-with-la/1682115?space=62&q=nodejs
Ref: https://github.com/actions/runner-images/blob/releases/win22/20220821/images/win/Windows2022-Readme.md
  • Loading branch information
@dennisameling
dennisameling committed Aug 23, 2022
commit ba4fd72e17ceab435873a9a73e5d7cca4e94332b
6 changes: 5 additions & 1 deletion .github/workflows/build-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ permissions:
jobs:
build-windows:
if: github.event.pull_request.draft == false
runs-on: windows-2019
strategy:
matrix:
windows: [windows-2019, windows-2022]
fail-fast: false
runs-on: ${{ matrix.windows }}
steps:
- uses: actions/checkout@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/coverage-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ permissions:
jobs:
coverage-windows:
if: github.event.pull_request.draft == false
runs-on: windows-2019
Copy link
Copy Markdown
Member

@gengjiawen gengjiawen Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should stays on windows-2019 since this need a more stable build env. As my experience, MSVC stability can't be guaranteed and take way to many time to fix.

runs-on: windows-2022
steps:
- uses: actions/checkout@v3
with:
Expand Down