Skip to content

stream: fix ReadableStreamReader.releaseLock() #44292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Aug 27, 2022
Merged

stream: fix ReadableStreamReader.releaseLock() #44292

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbd36fe
stream: fix `ReadableStreamReader.releaseLock()`
daeyeon Aug 15, 2022
512e2e7
fixup: remove comments
daeyeon Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: remove comments 
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
  • Loading branch information
@daeyeon
daeyeon committed Aug 19, 2022
commit 512e2e70cf6fceba4310703143018f542d143fe5
3 changes: 0 additions & 3 deletions test/parallel/test-whatwg-readablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,10 +328,7 @@ assert.throws(() => {
const read1 = reader.read();
const read2 = reader.read();

// The stream is empty so the read will never settle.
read1.then(common.mustNotCall(), common.mustCall());

// The stream is empty so the read will never settle.
read2.then(common.mustNotCall(), common.mustCall());

assert.notStrictEqual(read1, read2);
Expand Down