Skip to content

bootstrap: fixup Error.stackTraceLimit for user-land snapshot #44203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Aug 18, 2022
Merged

bootstrap: fixup Error.stackTraceLimit for user-land snapshot #44203

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d78a717
bootstrap: fixup Error.stackTraceLimit for user-land snapshot
joyeecheung Aug 10, 2022
6df1fae
fixup! bootstrap: fixup Error.stackTraceLimit for user-land snapshot
joyeecheung Aug 11, 2022
86dfc54
fixup! fixup! bootstrap: fixup Error.stackTraceLimit for user-land sn…
joyeecheung Aug 11, 2022
082f665
fixup! bootstrap: fixup Error.stackTraceLimit for user-land snapshot
joyeecheung Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! bootstrap: fixup Error.stackTraceLimit for user-land snapshot 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@joyeecheung @aduh95
joyeecheung and aduh95 authored Aug 17, 2022
commit 082f6656b958a834939124cc98590952a57d36a0
10 changes: 6 additions & 4 deletions lib/internal/main/mksnapshot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

const {
Error,
SafeSet,
SafeArrayIterator,
ObjectGetOwnPropertyDescriptor,
ObjectDefineProperty,
ObjectSetPrototypeOf
ObjectGetOwnPropertyDescriptor,
ObjectSetPrototypeOf,
SafeArrayIterator,
SafeSet,
} = primordials;

const binding = internalBinding('mksnapshot');
Expand Down Expand Up @@ -156,6 +156,8 @@ function main() {
stackTraceLimitDesc = ObjectGetOwnPropertyDescriptor(Error, 'stackTraceLimit');

if (stackTraceLimitDesc !== undefined) {
// We want to use null-prototype objects to not rely on globally mutable
// %Object.prototype%.
ObjectSetPrototypeOf(stackTraceLimitDesc, null);
Comment thread
joyeecheung marked this conversation as resolved.
process._rawDebug('Deleting Error.stackTraceLimit from the snapshot. ' +
'It will be re-installed after deserialization');
Expand Down