Skip to content

http: add writeEarlyHints function to ServerResponse #44180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Aug 17, 2022
Merged

http: add writeEarlyHints function to ServerResponse #44180

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3f31f7b
http: add writeEarlyHints function to ServerResponse
Aug 8, 2022
35ea4b9
add better regex pattern to match rfc8288 specs
Aug 11, 2022
961a8a5
http2: add writeEarlyHints to http2
Aug 13, 2022
e9d0be0
Update lib/internal/validators.js
wingleung Aug 16, 2022
82dea4c
http: tweak regex
Aug 16, 2022
c204024
add writeEarlyHints to http2 docs
Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/internal/validators.js 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@wingleung @lpinca
wingleung and lpinca authored Aug 16, 2022
commit e9d0be00d2be984051297bc3f12e866bdcdf3057
2 changes: 1 addition & 1 deletion lib/internal/validators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ function validateUnion(value, name, union) {
}

function validateLinkHeaderValue(value, name) {
const linkValueRegExp = /^((<([^>]*)>;)\s*(rel="?([^;]*)"?;?)\s*((as|anchor|title)="?(.*)"?)?)$/;
const linkValueRegExp = /^(?:<[^>]*>;)\s*(?:rel="?[^;]*"?;?)\s*(?:(?:as|anchor|title)="?.*"?)?$/;

if (
typeof value === 'undefined' ||
Expand Down